http: allow put_file()ing file-like objects #764
Conversation
|
This seems like it might be a useful thing to do for all filesystems. Possibly related: #723 |
|
I agree. It might require a bigger design discussion, but something I wondered when I started to the migration to the fsspec was why this was not supported natively (since that would potentially render the requirement to the callbacks redundant, since we could simply wrap |
isidentical
force-pushed
the
http-put-file-obj
branch
from
ddcddcb to
702c64f
Compare
|
Should be |
| self._raise_not_found_for_status(r, url) | ||
| return out | ||
|
|
||
| async def _get_file( |
There was a problem hiding this comment.
I think this one was right!
It says, "get file from remote to local", and should be the revers of put_file. That's how we have it in spec.
There was a problem hiding this comment.
Ah, missed that! Thanks for the correction.
This reverts commit df58af7.
Leftover from fsspec#764
2 participants
Since writing to
HTTPFileis not supported, currently you can not upload arbitrary streams (unlike other filesystems where you could open a new file in writing mode throughfs.open(path, 'wb')and copy the original stream throughshutil.copy_file_obj()to the new file). Not sure if this would be worth documenting at the moment, but would be extremely useful to compensate for the missingwmethod at the moment while we are thinking about other solutions.